internal: fix python abi library name for mingw#6159
Closed
ognevny wants to merge 1 commit into
Closed
Conversation
ognevny
changed the title
ognevny
force-pushed
the
fix-mingw-libname
branch
from
4bc82d4 to
162acea
Compare
Author
|
it seems that this didn't fix downstream builds. for me pyca/cryptography still fail :( @messense is there any place I missed? |
Member
|
I think we need to change here pyo3/pyo3-ffi/src/impl_/macros.rs Line 255 in b3aa7da |
ognevny
force-pushed
the
fix-mingw-libname
branch
from
162acea to
74ae95f
Compare
Author
that didn't help too... https://github.com/msys2/MINGW-packages/actions/runs/28220768771/job/83601338236?pr=29942 |
ognevny
force-pushed
the
fix-mingw-libname
branch
2 times, most recently
from
cde22a0 to
762e2f5
Compare
Author
|
probably adding +verbatim will help: https://github.com/microsoft/windows-rs/blob/f5c410d9328702a879af321107bb5334a129e991/crates/libs/link/src/lib.rs#L15 that didn't help too |
ognevny
force-pushed
the
fix-mingw-libname
branch
from
762e2f5 to
6dc29f9
Compare
ognevny
force-pushed
the
fix-mingw-libname
branch
4 times, most recently
from
baead02 to
dd1ee97
Compare
usually mingw version of python are shipped with `lib` prefix, so we need to add it for proper linking Co-authored-by: chiri <chirizxc@proton.me>
ognevny
force-pushed
the
fix-mingw-libname
branch
from
dd1ee97 to
2624fc4
Compare
Author
|
#6164 did it better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usually mingw version of python are shipped with
libprefix, so we need to add it for proper linkingfixes #6157